reorganize
This commit is contained in:
@@ -97,15 +97,7 @@ Inspecting the output of `get_some_transactions`, we see that there are multiple
|
|||||||
```
|
```
|
||||||
## Get **The Right** Transactions
|
## Get **The Right** Transactions
|
||||||
|
|
||||||
Looking at the transactions themselves, we see that there is a `category` field which sometimes has a list of values, sometimes `None`. Among the categories there are "Transfer", "Credit Card", and "Deposit": These aren't going to be useful in gleaning spending activity, so we'll refactor our `get_some_transactions` function to
|
Looking at the transactions themselves, we see that there is a `category` field which sometimes has a list of values, sometimes `None`.
|
||||||
|
|
||||||
1. skip transactions with those categories
|
|
||||||
2. skip accounts with a subtype of "savings" or "cd".
|
|
||||||
|
|
||||||
Let's also
|
|
||||||
|
|
||||||
3. make sure to get all available transactions by using pagination
|
|
||||||
4. just return transactions:
|
|
||||||
|
|
||||||
```python
|
```python
|
||||||
>>> some_transactions['transactions'].keys()
|
>>> some_transactions['transactions'].keys()
|
||||||
@@ -123,6 +115,17 @@ dict_keys(['account_id', 'account_owner', 'amount', 'category', 'category_id', '
|
|||||||
'Travel'}
|
'Travel'}
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|
||||||
|
Among the categories there are "Transfer", "Credit Card", and "Deposit": These aren't going to be useful in gleaning spending activity, so we'll refactor our `get_some_transactions` function to
|
||||||
|
1. skip transactions with those categories
|
||||||
|
2. skip accounts with a subtype of "savings" or "cd".
|
||||||
|
|
||||||
|
Let's also
|
||||||
|
|
||||||
|
3. make sure to get all available transactions by using pagination
|
||||||
|
4. just return transactions.
|
||||||
|
|
||||||
|
|
||||||
[get_some_transactions_v2.py](https://github.com/zevaverbach/spending_summary/blob/master/get_some_transactions_v2.py)
|
[get_some_transactions_v2.py](https://github.com/zevaverbach/spending_summary/blob/master/get_some_transactions_v2.py)
|
||||||
|
|
||||||
```python
|
```python
|
||||||
|
|||||||
Reference in New Issue
Block a user