zev/mux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix table-driven example documentation (#363)

Browse Source 
Prior to this change, the example documentation
found in the README.md has an errant code which
won't work in the table-driven code example.

This change modifies the variable name from `t` to `tc`
so it does not conflict with the `t *testing.T` struct
definition.

* Adds a range clause to the `for` statement
* Modifies `for` statement scope to use `tc.shouldPass`, and `tc.routeVariable`

Doc: https://github.com/gorilla/mux#testing-handlers
This commit is contained in:
brandon-height
2018-04-03 11:23:30 -07:00
committed by Kamil Kisiel
parent 4dbd923b0c
commit 94231ffd98
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
README.md
View File

@@ -593,8 +593,8 @@ func TestMetricsHandler(t *testing.T) {
{"adhadaeqm3k", false}, {"adhadaeqm3k", false},
} }
for _, t := tt { for _, tc := range tt {
path := fmt.Sprintf("/metrics/%s", t.routeVariable) path := fmt.Sprintf("/metrics/%s", tc.routeVariable)
req, err := http.NewRequest("GET", path, nil) req, err := http.NewRequest("GET", path, nil)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
@@ -606,9 +606,9 @@ func TestMetricsHandler(t *testing.T) {
// In this case, our MetricsHandler returns a non-200 response // In this case, our MetricsHandler returns a non-200 response
// for a route variable it doesn't know about. // for a route variable it doesn't know about.
if rr.Code == http.StatusOK && !t.shouldPass { if rr.Code == http.StatusOK && !tc.shouldPass {
t.Errorf("handler should have failed on routeVariable %s: got %v want %v", t.Errorf("handler should have failed on routeVariable %s: got %v want %v",
t.routeVariable, rr.Code, http.StatusOK) tc.routeVariable, rr.Code, http.StatusOK)
} }
} }
} }